Re: [PATCH] staging:iio:treewide only use shared to decide on interfaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/24/11 09:30, Lars-Peter Clausen wrote:
> On 10/21/2011 05:39 PM, Jonathan Cameron wrote:
>> Internally the fact that say scale is shared across channels is
>> actually of remarkably little interest.  Hence lets not store it.
>> Numerous devices have weird combinations of channels sharing
>> scale anyway so it is not as though this was really telling
>> us much. Note however that we do still use the shared sysfs
>> attrs thus massively reducing the number of attrs in complex
>> drivers.
>>
>> Side effect is that certain drivers that were abusing this
>> (mostly my work) needed to do a few more checks on what the
>> channel they are being queried on actually is.
>>
>> This is also helpful for in kernel interfaces where we
>> just want to query the scale and don't care whether it
>> is shared with other channels or not.
>>
>> Signed-off-by: Jonathan Cameron <jic23@xxxxxxxxx>
> 
> Hi
> 
> Seems to work. I think it makes sense to submit this one and the other,
> which removes the bitmask addressing, together. Will you take care of this?
Yes.  Might take a few days to hit though as I would guess Greg is going
to be busy at the kernel summit.

Are you happy to Ack this patch or if not give a tested-by.
Whilst I can push stuff on without review to Greg, I always prefer not to!

Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux