On 10/10/2011 10:41 AM, Jonathan Cameron wrote: > On 10/07/11 20:18, Lars-Peter Clausen wrote: >> I wanted to use the bulk regulator API at first but decided against it, so we >> can support the case where only some, but not all, of the channels are used and >> some channels don't have a supply for their vref. > That would be fair enough if you were actually supporting the ability to do that > in the driver. You aren't, so please use the bulk apis. > If this is added later, then that is the time to hand roll a custom version of this. Well, the idea was to be consistent with other DAC drivers, which simply report a scale value of 0 if no vref was specified. But I'll change it to use the bulk regulator API and let probe fail in case a vref regulator is missing. - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html