On 10/26/10 15:33, Guenter Roeck wrote: > On Tue, Oct 26, 2010 at 05:15:30AM -0400, Jonathan Cameron wrote: >> On 10/26/10 04:27, Zhang, Sonic wrote: >>> >>> >>>> -----Original Message----- >>>> From: Jonathan Cameron [mailto:jic23@xxxxxxxxx] >>>> Sent: Monday, October 25, 2010 6:54 AM >>>> To: Mike Frysinger >>>> Cc: linux-iio@xxxxxxxxxxxxxxx; >>>> device-drivers-devel@xxxxxxxxxxxxxxxxxxxx; Zhang, Sonic; Guenter Roeck >>>> Subject: Re: [PATCH 12/14] staging: iio: adc: new driver for >>>> ADT7408 temperature sensors >>>> >>>> On 10/23/10 21:29, Mike Frysinger wrote: >>>>> From: Sonic Zhang <sonic.zhang@xxxxxxxxxx> >>>> Here we enter new territory. This device is already supported >>>> in hwmon. Do we have a usecase that is not covered by that driver? >>>> >>> >>> I don't find a way to get event notification other than poll in hwmon >>> framework. So, I move all temperature devic with interrupt available >>> to IIO framework. >> >> Whilst it isn't often done (and is a little clunky). It is possible to select >> on sysfs attributes much like any other file. I'm sure Guenter can tell us >> if any current hwmon devices are doing this? > > One can always use sysfs_notify(). Not sure I understand what is clunky about it. > gpio-fan uses it, and I have used it as well in an internal driver. Works pretty well. > > I thought that is what was meant with "poll" [ie poll (2)], and somehow considered > to not be good enough. Would be nice to know the reasons, though, and how iio does > better than that. Maybe I need to spend some time reading the iio documentation. As a quick and dirty summary. IIO does it roughly the same way as input, be it heavily stripped down. Character device rather than sysfs for events. This is from memory, but I think the main issue with sysfs_notify is that, whilst you can poll on any file, all of those in a given directory will wake up on a call of sysfs_notify. In devices with one or two alarms that is probably fine as you can just read them all, but we have devices with 10s of different alarms. Hence you don't want to be reading lots of files to find out what is going on. A single alarm file would be fine if only one could trigger simultaneously, but that's rarely the case. Any sort of 'what alarm has triggered' mask is clunky and difficult to generalize. We try to use sysfs for what it is good at (low bandwidth direct reading from devices and configuration of those devices) and character devices for the high bandwidth stuff. Jonathan -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
