RE: [PATCH 2/3] staging:iio:sca3000 fix bug due to scan_element directory move.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jonathan Cameron wrote on 2010-10-07:
> The device found passed to the attr functions is that of the ring
> buffer, not the the iio_dev so we need to bounce through one more hop
> to get the right address.
>
> Reported-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> Signed-off-by: Jonathan Cameron <jic23@xxxxxxxxx>

Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>

> ---
>  drivers/staging/iio/accel/sca3000_ring.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> diff --git a/drivers/staging/iio/accel/sca3000_ring.c
> b/drivers/staging/iio/accel/sca3000_ring.c index 8186d2b..c872fdd 100644
> --- a/drivers/staging/iio/accel/sca3000_ring.c +++
> b/drivers/staging/iio/accel/sca3000_ring.c @@ -138,7 +138,8 @@ static
> ssize_t sca3000_show_ring_bpse(struct device *dev,  {
>       int len = 0, ret;
>       u8 *rx;
> -     struct iio_dev *indio_dev = dev_get_drvdata(dev);
> +     struct iio_ring_buffer *ring = dev_get_drvdata(dev);
> +     struct iio_dev *indio_dev = ring->indio_dev;
>       struct sca3000_state *st = indio_dev->dev_data;
>
>       mutex_lock(&st->lock);
> @@ -168,7 +169,8 @@ static ssize_t sca3000_store_ring_bpse(struct
> device *dev,
>                                     const char *buf,
>                                     size_t len)
>  {
> -     struct iio_dev *indio_dev = dev_get_drvdata(dev);
> +     struct iio_ring_buffer *ring = dev_get_drvdata(dev);
> +     struct iio_dev *indio_dev = ring->indio_dev;
>       struct sca3000_state *st = indio_dev->dev_data;
>       int ret;
>       u8 *rx;

Greetings,
Michael

Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft Muenchen, Registergericht Muenchen HRB 4036 Geschaeftsfuehrer Thomas Wessel, William A. Martin, Margaret Seif


--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux