On Tue, 2010-10-05 at 14:19 -0700, rklein@xxxxxxxxxx wrote: > Adding support for the ISL 29018 ambient light and proximity sensor. Trivial comments below. > diff --git a/drivers/staging/iio/light/isl29018.c b/drivers/staging/iio/light/isl29018.c [] > +static int isl29018_set_range(struct i2c_client *client, unsigned long range, > + unsigned int *new_range) > +{ > + unsigned long supp_ranges[] = {1000, 4000, 16000, 64000}; static const > +static int isl29018_set_resolution(struct i2c_client *client, > + unsigned long adcbit, unsigned int *conf_adc_bit) > +{ > + unsigned long supp_adcbit[] = {16, 12, 8, 4}; here too > +static int isl29018_chip_init(struct i2c_client *client) > +{ > + struct isl29018_chip *chip = i2c_get_clientdata(client); > + int status; > + int i; > + int new_adc_bit; > + unsigned int new_range; > + > + for (i = 0; i < ARRAY_SIZE(chip->reg_cache); i++) > + chip->reg_cache[i] = 0; memset? -- To unsubscribe from this list: send the line "unsubscribe linux-iio" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html