Re: [RFC PATCH 0/8 V2] staging:iio:imu driver merges, fixes and new features.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Gah, sorry all. I clearly had some rubbish still in the relevant directory, hence
this lot got sent twice.

On 09/22/10 12:47, Jonathan Cameron wrote:
> V2:
> 
> This is an updated version of the series incoporating the issues Manuel
> pointed out and the addition of the adis16367 support (which is trivial).
> Adding the adis16385 is more complex due to different types for the various
> inputs.  I'm not inclined to do that one without access to physical hardware
> or someone willing to do testing.
> 
> Rebased on top of the _type and _index series which is now in staging-next.
> 
> Still RFC as Manuel is tracking down an issue with buffered reading on an
> adis16400. Probably associated with the burst reading changes (I have
> no burst capable devices so could not test that part).
> 
> There are a few more things missing from these drivers that I intend to
> add at a later date.  The soft and hard iron calibration elements of the
> adis16400 magnetometer aren't currently exported and no drivers support
> changing the range of the gyroscopes.
> 
> All comments welcome and thanks to Manuel for testing the previous
> generation.  I've updated the copyright info to indicate the original
> source of a lot of this code (which is hidden otherwise as the adis16400
> driver no longer separately exists).
> 
> V1:
> 
> This is an RFC for two reasons. Firstly I haven't tested this as
> fully yet and will do so before merging.  I will do a whole
> lot more testing on the adis16350 that I have.  Coverage of the
> adis16300 and adis16400 would be great if anyone can do so.
> I also haven't done full testing on all the build combinations yet.
> (there is at least one known issue to clean up!)
> Secondly the event patch in particularly has some elements not seen
> elsewhere before that I would like people to consider.
> 
> Right now, only the adis16350 and adis16360 famillies are supported
> by the event support patch.  I'll add support for the other parts
> at a later date unless someone else beats me to it (hint!).  Note
> this patch now actually contains the adis16350_event.c file that
> was missing previously.
> 
> There is one effective change to all but the adis16400 ABIs.
> When we originally proposed the [m]_<type>_<modifier>_en
> attributes for scan modes I very carefully stated that the index
> [m] for a given device would not necessarily cover all values between
> 0 and the highest present.  It was exactly this possible driver
> merge that motivated that arguement. By allowing indexes to be
> missed, we can have single drivers supporting various subsets of
> sensor elements.  Here the devices are such that some interleaving
> is possible.  This reduces the storage required for the event code,
> so I have done it where possible.  Note the addition
> of new devices to this driver in future may change this again!
> 
> As ever, all comments welcome.  Any tested-bys with a part number
> would be particularly welcome.
> 
> Should be trivial to add the adis16367 and adis16385 to this driver.
> Does anyone have one of these parts to test?
> 
> Jonathan Cameron (7):
>   staging:iio:adis16350 add non burst buffer fill and fix burst logic
>   staging:iio:adis16350 move datardy trigger to straight interrupt.
>   staging:iio:adis16350 Add optional event support
>   staging:iio:adis16350 add missing registration of temp_offset attr
>   staging:iio:adis16300 merge into adis16350 driver
>   staging:iio:adis16400 merge into adis16350 driver
>   staging:iio:adis16350 add support for the adis16367
> 
> Manuel Stahl (1):
>   staging:iio:adis16350 bug in spi bus speed setup
> 
>  drivers/staging/iio/adc/adc.h               |    8 +-
>  drivers/staging/iio/gyro/gyro.h             |   31 +-
>  drivers/staging/iio/imu/Kconfig             |   30 +-
>  drivers/staging/iio/imu/Makefile            |    9 +-
>  drivers/staging/iio/imu/adis16300.h         |  184 -------
>  drivers/staging/iio/imu/adis16300_core.c    |  756 ---------------------------
>  drivers/staging/iio/imu/adis16300_ring.c    |  238 ---------
>  drivers/staging/iio/imu/adis16300_trigger.c |  125 -----
>  drivers/staging/iio/imu/adis16350.h         |  117 ++++-
>  drivers/staging/iio/imu/adis16350_core.c    |  335 +++++++++++--
>  drivers/staging/iio/imu/adis16350_event.c   |  499 ++++++++++++++++++
>  drivers/staging/iio/imu/adis16350_ring.c    |  215 +++++++-
>  drivers/staging/iio/imu/adis16350_trigger.c |   40 +-
>  drivers/staging/iio/imu/adis16400.h         |  208 --------
>  drivers/staging/iio/imu/adis16400_core.c    |  752 --------------------------
>  drivers/staging/iio/imu/adis16400_ring.c    |  248 ---------
>  drivers/staging/iio/imu/adis16400_trigger.c |  125 -----
>  drivers/staging/iio/sysfs.h                 |   17 +-
>  18 files changed, 1161 insertions(+), 2776 deletions(-)
>  delete mode 100644 drivers/staging/iio/imu/adis16300.h
>  delete mode 100644 drivers/staging/iio/imu/adis16300_core.c
>  delete mode 100644 drivers/staging/iio/imu/adis16300_ring.c
>  delete mode 100644 drivers/staging/iio/imu/adis16300_trigger.c
>  create mode 100644 drivers/staging/iio/imu/adis16350_event.c
>  delete mode 100644 drivers/staging/iio/imu/adis16400.h
>  delete mode 100644 drivers/staging/iio/imu/adis16400_core.c
>  delete mode 100644 drivers/staging/iio/imu/adis16400_ring.c
>  delete mode 100644 drivers/staging/iio/imu/adis16400_trigger.c
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux