Re: [Uclinux-dist-devel] [PATCH 1/3] staging: iio: new adis16201 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/07/10 06:14, Mike Frysinger wrote:
> On Sat, Aug 7, 2010 at 00:44, Mike Frysinger wrote:
>> IIO driver for dual Axis Accelerometer/inclinometer adis16201 parts.
> 
> on second thought, forget these.  they're using API that has been
> removed from current mainline and still need updating.
The abi changes are all trivial so I've done a quick patch set
(will send shortly).

Note that a few abi elements used were never in mainline.
I haven't ever taken the reset attribute definition.  I'm not sure it
is generally a good thing to encourage access to in a driver.  Exactly
what it means is fairly device specific (e.g. Do any calibration params
reset or not?  Do we write them to flash first or are we going back to
factory settings? Why do we need to allow userspace to do it at all?)
Obviously you guys have a reason to do it, so I've
been converting them to IIO_DEVICE_ATTR calls in the drivers.

Also, imu/volt.h was never merged as the relevant abi elements are in
adc/adc.h.

In this case we need to merge the fix patches (if you are happy with them)
into the underlying driver patches as otherwise we introduce a point at
which they won't compile.  I can do that if you like but might take me
a few days so if anyone else is willing....

Cheers,

Jonathan
--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Input]     [Linux Kernel]     [Linux SCSI]     [X.org]

  Powered by Linux