Re: [PATCH 0/8] Fix the remaining sloppy timeout typing in libata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/26/23 2:36 AM, Damien Le Moal wrote:
[...]
>> Here are 8 patches against the 'for-next' branch of Damien's 'libata.git' repo.
>>
>> The libata code still often uses the 'unsigned long' type for the millisecond
>> timeouts, while the kernel functions like msecs_to_jiffies() or msleep() only
>> take 'unsigned int' parameters for those. I've started fixing the timeout types
>> from ata_exec_internal[_sg]() that tripped the Svace static analyzer and posted
>> couple patches, promising to post a large continuation series somewhat later...
>> in my worst nightmare I couldn't imagine that this would take a whole year! :-(
> 
> Sergey,
> 
> Ping ? Are you resending this ?
> Need a rebase as this does not apply cleanly.

   I need to find the time for doing this...

>>
>> Sergey Shtylyov (8):
>>   ata: libata: fix parameter type of ata_deadline()
>>   ata: libata-core: fix parameter types of ata_wait_register()
>>   ata: libata-eh: fix reset timeout type
>>   ata: fix debounce timings type
>>   ata: libata-scsi: fix timeout type in ata_scsi_park_store()
>>   ata: libahci: fix parameter type of ahci_exec_polled_cmd()
>>   ata: ahci_xgene: fix parameter types of xgene_ahci_poll_reg_val()
>>   ata: sata_sil24: fix parameter type of sil24_exec_polled_cmd()
>>
>>  drivers/ata/ahci.c          |  2 +-
>>  drivers/ata/ahci_qoriq.c    |  2 +-
>>  drivers/ata/ahci_xgene.c    |  7 +++----
>>  drivers/ata/libahci.c       |  7 ++++---
>>  drivers/ata/libata-core.c   |  6 +++---
>>  drivers/ata/libata-eh.c     |  6 +++---
>>  drivers/ata/libata-sata.c   | 16 ++++++++--------
>>  drivers/ata/libata-scsi.c   |  4 ++--
>>  drivers/ata/libata-sff.c    |  2 +-
>>  drivers/ata/sata_highbank.c |  2 +-
>>  drivers/ata/sata_inic162x.c |  2 +-
>>  drivers/ata/sata_mv.c       |  2 +-
>>  drivers/ata/sata_nv.c       |  2 +-
>>  drivers/ata/sata_sil24.c    |  4 ++--
>>  include/linux/libata.h      | 24 ++++++++++++------------
>>  15 files changed, 44 insertions(+), 44 deletions(-)

MBR, Sergey



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux