On 7/26/23 11:02, Yang Yingliang wrote:
>
> On 2023/7/25 23:23, Sergey Shtylyov wrote:
>> On 7/25/23 3:28 PM, Yang Yingliang wrote:
>>
>>> The 'rv' will be set to 0 after calling of_property_read_reg(),
>>> return correct error code in the error path.
>>>
>>> Fixes: d0b2461678b1 ("ata: Use of_property_read_reg() to parse "reg"")
>>> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
>>> ---
>>> drivers/ata/pata_octeon_cf.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c
>>> index ff538b858928..6b46e20b3830 100644
>>> --- a/drivers/ata/pata_octeon_cf.c
>>> +++ b/drivers/ata/pata_octeon_cf.c
>>> @@ -893,12 +893,12 @@ static int octeon_cf_probe(struct platform_device *pdev)
>>> cs0 = devm_ioremap(&pdev->dev, res_cs0->start,
>>> resource_size(res_cs0));
>>> if (!cs0)
>>> - return rv;
>>> + return -EINVAL;
>> Hm, missed this one! Should be -ENOMEM as well.
> When ioremap cs1 fails, it returns -EINVAL, it needs be changed too. I
> will send a patch to modify it.
No need. I fixed that when applying the patch.
>
> Thanks,
> Yang
>>
>>>
>>> /* allocate host */
>>> host = ata_host_alloc(&pdev->dev, 1);
>>> if (!host)
>>> - return rv;
>>> + return -ENOMEM;
>> [...]
>>
>> MBR, Sergey
>>
>> .
--
Damien Le Moal
Western Digital Research
