Re: [PATCH v3 9/9] ata: remove deprecated EH callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 7/21/23 7:32 PM, Niklas Cassel wrote:

> From: Niklas Cassel <niklas.cassel@xxxxxxx>
> 
> Now when all libata drivers have migrated to use the error_handler
> callback, remove the deprecated phy_reset and eng_timeout callbacks.
> 
> Also remove references to non-existent functions sata_phy_reset and
> ata_qc_timeout from Documentation/driver-api/libata.rst.
> 
> Signed-off-by: Niklas Cassel <niklas.cassel@xxxxxxx>
[...]
> diff --git a/drivers/ata/pata_sl82c105.c b/drivers/ata/pata_sl82c105.c
> index 3b62ea482f1a..93882e976ede 100644
> --- a/drivers/ata/pata_sl82c105.c
> +++ b/drivers/ata/pata_sl82c105.c
> @@ -180,8 +180,7 @@ static void sl82c105_bmdma_start(struct ata_queued_cmd *qc)
>   *	document.
>   *
>   *	This function is also called to turn off DMA when a timeout occurs
> - *	during DMA operation. In both cases we need to reset the engine,
> - *	so no actual eng_timeout handler is required.
> + *	during DMA operation. In both cases we need to reset the engine.
>   *
>   *	We assume bmdma_stop is always called if bmdma_start as called. If
>   *	not then we may need to wrap qc_issue.

Reviewed-by: Sergey Shtylyov <s.shtylyov@xxxxxx>

[...]

MBR, Sergey



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux