Hi Geert,
thanks for your review!
On 4/11/19 11:56 PM, Geert Uytterhoeven wrote:
Hi Michael,
On Thu, Sep 26, 2019 at 5:54 AM Michael Schmitz <schmitzmic@xxxxxxxxx> wrote:
Autoloading of Falcon IDE driver modules requires converting
these drivers to platform drivers.
Add platform device for Falcon IDE interface in Atari platform
setup code in preparation for this.
Signed-off-by: Michael Schmitz <schmitzmic@xxxxxxxxx>
--
This should be a triple dash.
Changes from RFC
- fix region size (spotted by Szymon Bieganski <S.Bieganski@xxxxxxxxx>)
- define IDE interface address in atari/config.c, create platform device
always (suggested by Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>)
Changes from v1
- add error checking for Falcon IDE platform device register
Thanks for the update!
--- a/arch/m68k/atari/config.c
+++ b/arch/m68k/atari/config.c
@@ -939,6 +959,13 @@ int __init atari_platform_init(void)
atari_scsi_tt_rsrc, ARRAY_SIZE(atari_scsi_tt_rsrc));
#endif
+ if (ATARIHW_PRESENT(IDE)) {
+ pdev = platform_device_register_simple("atari-falcon-ide", -1,
+ atari_falconide_rsrc, ARRAY_SIZE(atari_falconide_rsrc));
+ if (IS_ERR(pdev))
+ rv = PTR_ERR(pdev);
+ }
+
return rv;
}
This breaks both falconide and pata_falcon, as it marks the resource
busy:
ide: Falcon IDE controller
falconide: resources busy
and
pata_falcon: Atari Falcon PATA controller
pata_falcon: resources busy
For pata_falcon, that regression can easily be fixed by merging both patches.
I obviously need to test this again, but from what I remember from my
last testing, falconide still worked OK after applying both patches.
That would have been without loading pata_falcon at all.
I'll rewrite falconide to use the same platform device as pata_falcon.
Cheers,
Michael
For falconide, I think the sensible thing to do is just remove the driver.
But before that, the defconfigs should be updated to use pata_falcon
instead of falconide.
For the actual code changes:
Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
Gr{oetje,eeting}s,
Geert
