Hi Geert,
Am 05.11.2019 um 10:09 schrieb Michael Schmitz:
--- a/arch/m68k/atari/config.c
+++ b/arch/m68k/atari/config.c
@@ -939,6 +959,13 @@ int __init atari_platform_init(void)
atari_scsi_tt_rsrc,
ARRAY_SIZE(atari_scsi_tt_rsrc));
#endif
+ if (ATARIHW_PRESENT(IDE)) {
+ pdev =
platform_device_register_simple("atari-falcon-ide", -1,
+ atari_falconide_rsrc,
ARRAY_SIZE(atari_falconide_rsrc));
+ if (IS_ERR(pdev))
+ rv = PTR_ERR(pdev);
+ }
+
return rv;
}
This breaks both falconide and pata_falcon, as it marks the resource
busy:
ide: Falcon IDE controller
falconide: resources busy
and
pata_falcon: Atari Falcon PATA controller
pata_falcon: resources busy
For pata_falcon, that regression can easily be fixed by merging both
patches.
I obviously need to test this again, but from what I remember from my
last testing, falconide still worked OK after applying both patches.
No idea what happened on that test, but booting a kernel with these
patches applied on real hardware indeed does see the (builtin) driver
fail to load.
That would have been without loading pata_falcon at all.
I'll rewrite falconide to use the same platform device as pata_falcon.
Just sent a patch for that in order to get some review - will combine
with the two earlier patches once it's in acceptable shape.
Cheers,
Michael