Hi Michael, On Mon, Nov 4, 2019 at 8:17 PM Michael Schmitz <schmitzmic@xxxxxxxxx> wrote: > On 5/11/19 12:04 AM, Geert Uytterhoeven wrote: > > On Mon, Oct 28, 2019 at 8:03 AM Michael Schmitz <schmitzmic@xxxxxxxxx> wrote: > >> Am 27.10.2019 um 07:17 schrieb Geert Uytterhoeven: > >>>> Who's going to pick this one up? I can do it, but it'd be nice to have > >>>> m68k on patch 1 first. > >>> Sorry for the late reply. I'll have a closer look after ELC-E, and will apply > >>> to the m68k tree if it passes. > >>> > >>> BTW, I believe v1 of both patches has been acked by Bartlomiej? > >> Correct - on July 3rd. I totally forgot about that, and didn't add his > >> Acked-by in v2, sorry. > > OK. > > > > I was about to queue the combined patch, until I realized the defconfigs > > default to falconide, which is broken by patch 1/2. > > My proposed solution for that is: > > 1. Switch the defconfigs from falconide to pata_falcon, > > Ack. > > > 2. Remove the legacy falconide driver. > > Nack - I still use that one (because pata_falcon has no support for > using interrupts with the Falcon IDE interface, and I'm unsure how much > more kernel bloat libata will add). Need to check the impact of > switching to pata_falcon first. Oh, I forgot about that. So yes, in that case pata_falcon is not a viable alternative yet. However, that means we can only avoid regressions by converting falconide to the new platform device, too, and doing that together, atomically, with your 2 patches in this series. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds