On 11/07/2018 07:29 PM, Sergei Shtylyov wrote: >>>> Interrupt vector 0 is valid on some platform. falcon driver wrongly >>>> treated interrupt vector 0 as invalid. We fix it in libata, and fix it >>>> in this driver as well. >>>> >>>> Signed-off-by: Chaohong guo <chaohong.guo@xxxxxxxxx> >>> >>> This patch should be folded into patch #1 (otherwise it breaks >>> bisectability). >>> >>> There are also other libata drivers using polling mode that need >>> updating: pata_palmld.c and pata_platform.c. >> >> Looks like there'd be a more subtle breaksage in sata_mv.c with the DT case -- >> we need to translate 0 returned from irq_of_parse_and_map() to a error code like >> -EINVAL... else we'd register IRQ0 when there's no IRQ. > > pata_samsung_cf.c also needs fixing in the same patch #1... And pata_octeon_cf.c too... >> [...] >>> Best regards, >>> -- >>> Bartlomiej Zolnierkiewicz >>> Samsung R&D Institute Poland >>> Samsung Electronics MBR, Sergei