Re: [PATCH v3 3/4] fix an IRQ0 interrupt issue in falcon pata driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/06/2018 05:42 AM, Chaohong guo wrote:

> Interrupt vector 0 is valid on some platform. falcon driver wrongly
> treated interrupt vector 0 as invalid. We fix it in libata, and fix it
> in this driver as well.
> 
>     Signed-off-by: Chaohong guo <chaohong.guo@xxxxxxxxx>
> ---
>  drivers/ata/pata_falcon.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/pata_falcon.c b/drivers/ata/pata_falcon.c
> index 41e0d6a6cd05..a991053aee87 100644
> --- a/drivers/ata/pata_falcon.c
> +++ b/drivers/ata/pata_falcon.c
> @@ -171,7 +171,7 @@ static int pata_falcon_init_one(void)
>  		      (unsigned long)base + ATA_HD_CONTROL);
>  
>  	/* activate */
> -	return ata_host_activate(host, 0, NULL, 0, &pata_falcon_sht);
> +	return ata_host_activate(host, -1, NULL, 0, &pata_falcon_sht);

   I'd prefer smth like -EINVAL to -1.

MBR, Sergei



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux