Re: [PATCH v3 3/4] fix an IRQ0 interrupt issue in falcon pata driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/06/2018 06:04 PM, Sergei Shtylyov wrote:

>>> Interrupt vector 0 is valid on some platform. falcon driver wrongly
>>> treated interrupt vector 0 as invalid. We fix it in libata, and fix it
>>> in this driver as well.
>>>
>>>     Signed-off-by: Chaohong guo <chaohong.guo@xxxxxxxxx>
>>
>> This patch should be folded into patch #1 (otherwise it breaks
>> bisectability).
>>
>> There are also other libata drivers using polling mode that need
>> updating: pata_palmld.c and pata_platform.c.
> 
>    Looks like there'd be a more subtle breaksage in sata_mv.c with the DT case --
> we need to translate 0 returned from irq_of_parse_and_map() to a error code like
> -EINVAL... else we'd register IRQ0 when there's no IRQ.

   pata_samsung_cf.c also needs fixing in the same patch #1...

> [...]
>> Best regards,
>> --
>> Bartlomiej Zolnierkiewicz
>> Samsung R&D Institute Poland
>> Samsung Electronics

MBR, Sergei



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux