Re: [PATCH] libata: Apply NOLPM quirk for Samsung PM830 / CXM13D1Q

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 05/13/2018 02:13 PM, François Cami wrote:
On Sun, May 13, 2018 at 11:49 AM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
Hi,


On 05/13/2018 12:57 AM, François Cami wrote:

Hi Tejun, Hans,

The SAMSUNG SSD PM830 factory-installed in my Dell XPS 13 (Ivy Bridge)
works fine with older kernels, but exhibits ata errors in recent
4.16.x kernels:

      [    1.090154] ata1.00: ATA-8: SAMSUNG SSD PM830 mSATA 256GB,
      CXM13D1Q, max UDMA/133
      (...)
      [  345.154996] ata1.00: exception Emask 0x40 SAct 0x0 SErr 0xc0800
action 0x6
      [  345.155006] ata1.00: irq_stat 0x40000001
      [  345.155013] ata1: SError: { HostInt CommWake 10B8B }
      [  345.155018] ata1.00: failed command: SET FEATURES
      [  345.155032] ata1.00: cmd ef/05:e1:00:00:00/00:00:00:00:00/40 tag 7
                              res 51/04:e1:00:00:00/00:00:00:00:00/40
Emask 0x41 (internal error)
      [  345.155038] ata1.00: status: { DRDY ERR }
      [  345.155042] ata1.00: error: { ABRT }
      [  345.155051] ata1: hard resetting link
      [  345.465661] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
      [  345.466955] ata1.00: configured for UDMA/133
      [  345.467085] ata1: EH complete

Could you please review & apply the attached patch (git format-patch)?

In short:
+        { "SAMSUNG SSD PM830 mSATA 256GB", "CXM13D1Q", ATA_HORKAGE_NOLPM,
},


This is the second report of the msata version of the 830 (both are PM830
drives)
having issues with LPM, at least for the "CXM13D1Q" and the "CXM14M1Q"
firmware versions.

Can you change your patch to replace the 256GB part with a "*" I believe
all capacities will be broken and then officially submit this upstream with
my:

Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Added please?

Thanks for the review - patch changed as requested attached.
Tejun, Hans, would you like me to send it directly to lkml?

Yes please git send-email it to Tejun, me and the appropriate lists.

Regards,

Hans


--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux