[PATCH] libata: Apply NOLPM quirk for Samsung PM830 / CXM13D1Q

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tejun, Hans,

The SAMSUNG SSD PM830 factory-installed in my Dell XPS 13 (Ivy Bridge)
works fine with older kernels, but exhibits ata errors in recent
4.16.x kernels:

    [    1.090154] ata1.00: ATA-8: SAMSUNG SSD PM830 mSATA 256GB,
    CXM13D1Q, max UDMA/133
    (...)
    [  345.154996] ata1.00: exception Emask 0x40 SAct 0x0 SErr 0xc0800
action 0x6
    [  345.155006] ata1.00: irq_stat 0x40000001
    [  345.155013] ata1: SError: { HostInt CommWake 10B8B }
    [  345.155018] ata1.00: failed command: SET FEATURES
    [  345.155032] ata1.00: cmd ef/05:e1:00:00:00/00:00:00:00:00/40 tag 7
                            res 51/04:e1:00:00:00/00:00:00:00:00/40
Emask 0x41 (internal error)
    [  345.155038] ata1.00: status: { DRDY ERR }
    [  345.155042] ata1.00: error: { ABRT }
    [  345.155051] ata1: hard resetting link
    [  345.465661] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
    [  345.466955] ata1.00: configured for UDMA/133
    [  345.467085] ata1: EH complete

Could you please review & apply the attached patch (git format-patch)?

In short:
+        { "SAMSUNG SSD PM830 mSATA 256GB", "CXM13D1Q", ATA_HORKAGE_NOLPM, },
fixes the errors.

Cheers
François
From bcb191ae6a5576b642eeec1de042bf9ba8545a9f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois=20Cami?= <fcami@xxxxxxxxxxxxxxxxx>
Date: Sat, 12 May 2018 21:34:47 +0200
Subject: [PATCH] libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.

Without this patch the drive errors out regularly:

[    1.090154] ata1.00: ATA-8: SAMSUNG SSD PM830 mSATA 256GB,
CXM13D1Q, max UDMA/133
(...)
[  345.154996] ata1.00: exception Emask 0x40 SAct 0x0 SErr 0xc0800 action 0x6
[  345.155006] ata1.00: irq_stat 0x40000001
[  345.155013] ata1: SError: { HostInt CommWake 10B8B }
[  345.155018] ata1.00: failed command: SET FEATURES
[  345.155032] ata1.00: cmd ef/05:e1:00:00:00/00:00:00:00:00/40 tag 7
                        res 51/04:e1:00:00:00/00:00:00:00:00/40 Emask 0x41 (internal error)
[  345.155038] ata1.00: status: { DRDY ERR }
[  345.155042] ata1.00: error: { ABRT }
[  345.155051] ata1: hard resetting link
[  345.465661] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[  345.466955] ata1.00: configured for UDMA/133
[  345.467085] ata1: EH complete
---
 drivers/ata/libata-core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 68596bd4cf06..316eef0f5158 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4549,8 +4549,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
 						ATA_HORKAGE_ZERO_AFTER_TRIM |
 						ATA_HORKAGE_NOLPM, },
 
-	/* This specific Samsung model/firmware-rev does not handle LPM well */
+	/* These specific Samsung model/firmware-rev do not handle LPM well */
 	{ "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
+	{ "SAMSUNG SSD PM830 mSATA 256GB", "CXM13D1Q", ATA_HORKAGE_NOLPM, },
 
 	/* Sandisk devices which are known to not handle LPM well */
 	{ "SanDisk SD7UB3Q*G1001",	NULL,	ATA_HORKAGE_NOLPM, },
-- 
2.17.0


[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux