On Sun, May 13, 2018 at 11:49 AM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote:
> Hi,
>
>
> On 05/13/2018 12:57 AM, François Cami wrote:
>>
>> Hi Tejun, Hans,
>>
>> The SAMSUNG SSD PM830 factory-installed in my Dell XPS 13 (Ivy Bridge)
>> works fine with older kernels, but exhibits ata errors in recent
>> 4.16.x kernels:
>>
>> [ 1.090154] ata1.00: ATA-8: SAMSUNG SSD PM830 mSATA 256GB,
>> CXM13D1Q, max UDMA/133
>> (...)
>> [ 345.154996] ata1.00: exception Emask 0x40 SAct 0x0 SErr 0xc0800
>> action 0x6
>> [ 345.155006] ata1.00: irq_stat 0x40000001
>> [ 345.155013] ata1: SError: { HostInt CommWake 10B8B }
>> [ 345.155018] ata1.00: failed command: SET FEATURES
>> [ 345.155032] ata1.00: cmd ef/05:e1:00:00:00/00:00:00:00:00/40 tag 7
>> res 51/04:e1:00:00:00/00:00:00:00:00/40
>> Emask 0x41 (internal error)
>> [ 345.155038] ata1.00: status: { DRDY ERR }
>> [ 345.155042] ata1.00: error: { ABRT }
>> [ 345.155051] ata1: hard resetting link
>> [ 345.465661] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
>> [ 345.466955] ata1.00: configured for UDMA/133
>> [ 345.467085] ata1: EH complete
>>
>> Could you please review & apply the attached patch (git format-patch)?
>>
>> In short:
>> + { "SAMSUNG SSD PM830 mSATA 256GB", "CXM13D1Q", ATA_HORKAGE_NOLPM,
>> },
>
>
> This is the second report of the msata version of the 830 (both are PM830
> drives)
> having issues with LPM, at least for the "CXM13D1Q" and the "CXM14M1Q"
> firmware versions.
>
> Can you change your patch to replace the 256GB part with a "*" I believe
> all capacities will be broken and then officially submit this upstream with
> my:
>
> Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>
> Added please?
Thanks for the review - patch changed as requested attached.
Tejun, Hans, would you like me to send it directly to lkml?
Regards,
François
> Thanks & Regards,
>
> Hans
>
From 365aa48237b49ae35f965076892fc79ccf029bee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fran=C3=A7ois=20Cami?= <fcami@xxxxxxxxxxxxxxxxx>
Date: Sat, 12 May 2018 21:34:47 +0200
Subject: [PATCH] libata: Apply NOLPM quirk for SAMSUNG PM830 CXM13D1Q.
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Without this patch the drive errors out regularly:
[ 1.090154] ata1.00: ATA-8: SAMSUNG SSD PM830 mSATA 256GB,
CXM13D1Q, max UDMA/133
(...)
[ 345.154996] ata1.00: exception Emask 0x40 SAct 0x0 SErr 0xc0800 action 0x6
[ 345.155006] ata1.00: irq_stat 0x40000001
[ 345.155013] ata1: SError: { HostInt CommWake 10B8B }
[ 345.155018] ata1.00: failed command: SET FEATURES
[ 345.155032] ata1.00: cmd ef/05:e1:00:00:00/00:00:00:00:00/40 tag 7
res 51/04:e1:00:00:00/00:00:00:00:00/40 Emask 0x41 (internal error)
[ 345.155038] ata1.00: status: { DRDY ERR }
[ 345.155042] ata1.00: error: { ABRT }
[ 345.155051] ata1: hard resetting link
[ 345.465661] ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300)
[ 345.466955] ata1.00: configured for UDMA/133
[ 345.467085] ata1: EH complete
Signed-off-by: François Cami <fcami@xxxxxxxxxxxxxxxxx>
Acked-by: Hans de Goede <hdegoede@xxxxxxxxxx>
---
drivers/ata/libata-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 68596bd4cf06..1ca365f13040 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -4549,8 +4549,9 @@ static const struct ata_blacklist_entry ata_device_blacklist [] = {
ATA_HORKAGE_ZERO_AFTER_TRIM |
ATA_HORKAGE_NOLPM, },
- /* This specific Samsung model/firmware-rev does not handle LPM well */
+ /* These specific Samsung models/firmware-revs do not handle LPM well */
{ "SAMSUNG MZMPC128HBFU-000MV", "CXM14M1Q", ATA_HORKAGE_NOLPM, },
+ { "SAMSUNG SSD PM830 mSATA *", "CXM13D1Q", ATA_HORKAGE_NOLPM, },
/* Sandisk devices which are known to not handle LPM well */
{ "SanDisk SD7UB3Q*G1001", NULL, ATA_HORKAGE_NOLPM, },
--
2.17.0
