>-----Original Message----- >From: Thierry Reding [mailto:thierry.reding@xxxxxxxxx] >Sent: Monday, February 19, 2018 7:58 PM >To: Preetham Chandru <pchandru@xxxxxxxxxx> >Cc: tj@xxxxxxxxxx; cyndis@xxxxxxxx; robh+dt@xxxxxxxxxx; >mark.rutland@xxxxxxx; devicetree@xxxxxxxxxxxxxxx; preetham260@xxxxxxxxx; >linux-tegra@xxxxxxxxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx; Venu Byravarasu ><vbyravarasu@xxxxxxxxxx>; Pavan Kunapuli <pkunapuli@xxxxxxxxxx> >Subject: Re: [PATCH V7 1/7] dt-bindings: ahci-tegra: add binding documentation > >On Mon, Feb 12, 2018 at 10:56:40PM +0530, Preetham Chandru Ramchandra >wrote: >> From: Preetham Ramchandra <pchandru@xxxxxxxxxx> >> >> This adds bindings documentation for the AHCI controller on Tegra210 > >Please avoid lines that are too short. They shouldn't exceed 72 characters, but >you're supposed to make fully use of those. Also the above is a sentence, so >should end with a '.'. > okay >> diff --git >> a/Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt >> b/Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt >> index 66c83c3e8915..0f4520a00716 100644 >> --- a/Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt >> +++ b/Documentation/devicetree/bindings/ata/nvidia,tegra124-ahci.txt >> @@ -1,20 +1,19 @@ >> -Tegra124 SoC SATA AHCI controller >> +Tegra SoC SATA AHCI controller >> >> Required properties : >> -- compatible : For Tegra124, must contain "nvidia,tegra124-ahci". >> Otherwise, >> - must contain '"nvidia,<chip>-ahci", "nvidia,tegra124-ahci"', where >> <chip> >> - is tegra132. >> -- reg : Should contain 2 entries: >> +- compatible : Must be one of: >> + - Tegra124 : "nvidia,tegra124-ahci" >> + - Tegra210 : "nvidia,tegra210-ahci" >> +- reg : Should contain 3 entries: >> - AHCI register set (SATA BAR5) >> - SATA register set >> + - AUX register set >> - interrupts : Defines the interrupt used by SATA >> - clocks : Must contain an entry for each entry in clock-names. >> See ../clocks/clock-bindings.txt for details. >> - clock-names : Must include the following entries: >> - sata >> - sata-oob >> - - cml1 >> - - pll_e >> - resets : Must contain an entry for each entry in reset-names. >> See ../reset/reset.txt for details. >> - reset-names : Must include the following entries: >> @@ -24,9 +23,19 @@ Required properties : >> - phys : Must contain an entry for each entry in phy-names. >> See ../phy/phy-bindings.txt for details. >> - phy-names : Must include the following entries: >> - - sata-phy : XUSB PADCTL SATA PHY >> -- hvdd-supply : Defines the SATA HVDD regulator >> -- vddio-supply : Defines the SATA VDDIO regulator >> -- avdd-supply : Defines the SATA AVDD regulator >> -- target-5v-supply : Defines the SATA 5V power regulator >> -- target-12v-supply : Defines the SATA 12V power regulator >> + - For T124: >> + - sata-phy : XUSB PADCTL SATA PHY >> + - For T210: >> + - sata-0 >> +- For T124: > >Can we please use TegraXYZ here? I find it useful to be consistent here because >those will show up if I grep for "tegra", whereas TXYZ won't. > okay >Thierry -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
