Quoting "Gustavo A. R. Silva" <garsilva@xxxxxxxxxxxxxx>:
Hi Tejun, Sergei,
Quoting Tejun Heo <tj@xxxxxxxxxx>:
On Fri, Jun 30, 2017 at 12:42:38PM +0300, Sergei Shtylyov wrote:
Hello!
On 6/30/2017 8:22 AM, Gustavo A. R. Silva wrote:
Print error message and propagate the return value of
platform_get_irq on failure.
You should have probably mentioned that this function no longer returns 0
on error.
Yeah, the patches looks good to me but I'd really appreciate more
context in the changelogs. Gustavo, can you please respin the
patches?
Absolutely.
What do you think about the following changelog:
platform_get_irq() returns an error code, but the sata_rcar driver
ignores it and always returns -EINVAL. This is not correct, and
prevents -EPROBE_DEFER from being propagated properly.
Print error message and propagate the return value of platform_get_irq
on failure. Also, with this change function sata_rcar_probe() no longer
returns 0 on error.
Errata, this would be final the chagelog:
platform_get_irq() returns an error code, but the sata_rcar driver
ignores it and always returns -EINVAL. This is not correct, and
prevents -EPROBE_DEFER from being propagated properly. Also,
notice that platform_get_irq() no longer returns 0 on error.
Print error message and propagate the return value of platform_get_irq
on failure.
Thanks
--
Gustavo A. R. Silva
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
