Hi Sergei,
Quoting Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>:
On 06/30/2017 10:36 PM, Gustavo A. R. Silva wrote:
Print error message and propagate the return value of
platform_get_irq on failure.
You should have probably mentioned that this function no longer
returns 0
on error.
Yeah, the patches looks good to me but I'd really appreciate more
context in the changelogs. Gustavo, can you please respin the
patches?
Absolutely.
What do you think about the following changelog:
platform_get_irq() returns an error code, but the sata_rcar driver
ignores it and always returns -EINVAL. This is not correct, and
This *was* correct, because it prevented returning 0 on error.
Yeah, I got it.
prevents -EPROBE_DEFER from being propagated properly.
Yes, this is a real problem.
Print error message and propagate the return value of platform_get_irq
on failure. Also, with this change function sata_rcar_probe() no longer
returns 0 on error.
It never did -- I was talking about platform_get_irq() which
might return 0 on error until I fixed it:
Yep, I sent a new email immediately after I realized this was
incorrect. Please,
check it out.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af
Great work!
Thank you
--
Gustavo A. R. Silva
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
