Re: [PATCH] Check return code from pdc20621_i2c_read()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 08/03/2015 06:42 PM, Sergei Shtylyov wrote:

    Please use pr_err() instead. And "0x%d" makes no sense at all, please
use "%#x" instead.

Yeah, not sure what I was drinking before writing this 0x%d thing...

Regarding the pr_err() - it is not used at all in this file, and
printk() is used instead.

Didn't notice before: the patch subject should start with the driver name and a colon, "sats_sx4: ".

--Tomer

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux