Re: [PATCH] libahci: ahci interrupt check for disabled port since private_data may be NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 17, 2014 at 09:45:43AM -0400, Tejun Heo wrote:
> > 	if (pp)
> > 		rc = devm_request_threaded_irq(..., irq + i, ...)
> > 	else
> > 		disable_irq(irq + i);
> 
> Ah, was looking at the old code.  But again, we didn't even request
> the irq, why would we disable it?

The driver does not request IRQs for dummy ports, but it still requests
MSIs for them. The MSI framework initializes the resources for all MSIs
(IRQ #s, CPU interrupt vectors). Hence, although we do not request a
IRQ #, it still exists - just with no handler associated with the driver.
IOW - with a default handler, which would probably complain loudly once
an interrupt from a dummy port comes (I suppose David could check it).

So if we just disable dummy port's IRQ #s we should never hear from them.

> Thanks.
> 
> -- 
> tejun

-- 
Regards,
Alexander Gordeev
agordeev@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux