On Tue, Apr 15, 2014 at 02:20:01PM -0400, Tejun Heo wrote:
> On Tue, Apr 15, 2014 at 01:18:12PM -0500, David Milburn wrote:
> > This patch also solves the problem, would this better?
>
> Yes, this is a lot better. Alexander, does this look good to you?
Yep, apart from a minor comment below.
Also, we're not going to see complains on spurious interrupts, aren't we?
> Also, shouldn't this cc stable?
>
> > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> > index 5a0bf8e..831b1b4 100644
> > --- a/drivers/ata/ahci.c
> > +++ b/drivers/ata/ahci.c
> > @@ -1236,14 +1236,14 @@ int ahci_host_activate(struct ata_host *host, int irq, unsigned int n_msis)
> > struct ahci_port_priv *pp = host->ports[i]->private_data;
> >
> > /* pp is NULL for dummy ports */
> > - if (pp)
> > + if (pp) {
> > desc = pp->irq_desc;
> > - else
> > - desc = dev_driver_string(host->dev);
> >
> > - rc = devm_request_threaded_irq(host->dev,
> > - irq + i, ahci_hw_interrupt, ahci_thread_fn, IRQF_SHARED,
> > - desc, host->ports[i]);
> > + rc = devm_request_threaded_irq(host->dev,
> > + irq + i, ahci_hw_interrupt, ahci_thread_fn, IRQF_SHARED,
> > + desc, host->ports[i]);
We could dereference 'pp->irq_desc' here and get rid of 'desc' variable.
> > + }
> > +
> > if (rc)
> > goto out_free_irqs;
> > }
>
> --
> tejun
--
Regards,
Alexander Gordeev
agordeev@xxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
