On Thu, Apr 17, 2014 at 02:44:36PM +0200, Alexander Gordeev wrote: > On Thu, Apr 17, 2014 at 09:29:42AM -0400, Tejun Heo wrote: > > On Thu, Apr 17, 2014 at 10:29:35AM +0200, Alexander Gordeev wrote: > > > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c > > > index e45b18e..9f1169a 100644 > > > --- a/drivers/ata/ahci.c > > > +++ b/drivers/ata/ahci.c > > > @@ -1240,6 +1240,8 @@ int ahci_host_activate(struct ata_host *host, int irq, unsigned int n_msis) > > > irq + i, ahci_hw_interrupt, > > > ahci_thread_fn, IRQF_SHARED, > > > pp->irq_desc, host->ports[i]); > > > + else > > > + disable_irq(irq + i); > > > > Hmmm? Request failed. Why would it require an explicit disable? > > if (pp) > rc = devm_request_threaded_irq(..., irq + i, ...) > else > disable_irq(irq + i); Ah, was looking at the old code. But again, we didn't even request the irq, why would we disable it? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
