On 04/16/2014 10:19 AM, Tejun Heo wrote:
Hello,
On Wed, Apr 16, 2014 at 09:39:19AM +0200, Alexander Gordeev wrote:
On Tue, Apr 15, 2014 at 02:20:01PM -0400, Tejun Heo wrote:
On Tue, Apr 15, 2014 at 01:18:12PM -0500, David Milburn wrote:
This patch also solves the problem, would this better?
Yes, this is a lot better. Alexander, does this look good to you?
Yep, apart from a minor comment below.
Also, we're not going to see complains on spurious interrupts, aren't we?
The irq isn't even requested, it won't reach the kernel at all.
Also, shouldn't this cc stable?
Yeap, I think so.
- rc = devm_request_threaded_irq(host->dev,
- irq + i, ahci_hw_interrupt, ahci_thread_fn, IRQF_SHARED,
- desc, host->ports[i]);
+ rc = devm_request_threaded_irq(host->dev,
+ irq + i, ahci_hw_interrupt, ahci_thread_fn, IRQF_SHARED,
+ desc, host->ports[i]);
We could dereference 'pp->irq_desc' here and get rid of 'desc' variable.
David, can you please update the patch accordingly?
Hi,
Sure, I have successfully re-tested, I will re-submit the
patch.
Thanks,
David
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
