On Sat, Feb 15, 2014 at 6:38 PM, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote: >> irq = platform_get_irq(pdev, 0); >> if (irq <= 0) >> - return -EINVAL; >> + return irq; > > > If returned IRQ is 0 (unused), you'll return 0, indicating probe success > while actually it failed. We need somewhat more complicated code here. Right, then we should do this instead: irq = platform_get_irq(pdev, 0); if (irq < 0) return irq; Regards, Fabio Estevam -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html