Hello. On 15-02-2014 16:50, Fabio Estevam wrote:
From: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx>
No need to return a 'fake' return value on platform_get_irq() failure.
Just return the error code itself instead.
Signed-off-by: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> --- drivers/ata/pata_imx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_imx.c b/drivers/ata/pata_imx.c index 50e2cf2..1af71b7 100644 --- a/drivers/ata/pata_imx.c +++ b/drivers/ata/pata_imx.c @@ -101,7 +101,7 @@ static int pata_imx_probe(struct platform_device *pdev) irq = platform_get_irq(pdev, 0); if (irq <= 0) - return -EINVAL; + return irq;
If returned IRQ is 0 (unused), you'll return 0, indicating probe success while actually it failed. We need somewhat more complicated code here.
WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
