On Tuesday 04 February 2014 11:03 PM, Andrew Lunn wrote:
> Make use of devm_phy_optional_get() in order to fix probe failures on
> Armada 370, XP and others, when there is no phy driver available.
>
> Signed-off-by: Andrew Lunn <andrew@xxxxxxx>
> Tested-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx>
> Acked-by: Tejun Heo <tj@xxxxxxxxxx>
Acked-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> ---
> v2
> No change
> v3
> Fix commit log devm_get_optional->devm_option_get.
> v4
> Add Tested-by: & Acked-by:
> Fix comment again.
> ---
> drivers/ata/sata_mv.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> index 20a7517bd339..52b8181ddafd 100644
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -4126,12 +4126,14 @@ static int mv_platform_probe(struct platform_device *pdev)
> clk_prepare_enable(hpriv->port_clks[port]);
>
> sprintf(port_number, "port%d", port);
> - hpriv->port_phys[port] = devm_phy_get(&pdev->dev, port_number);
> + hpriv->port_phys[port] = devm_phy_optional_get(&pdev->dev,
> + port_number);
> if (IS_ERR(hpriv->port_phys[port])) {
> rc = PTR_ERR(hpriv->port_phys[port]);
> hpriv->port_phys[port] = NULL;
> - if ((rc != -EPROBE_DEFER) && (rc != -ENODEV))
> - dev_warn(&pdev->dev, "error getting phy");
> + if (rc != -EPROBE_DEFER)
> + dev_warn(&pdev->dev, "error getting phy %d",
> + rc);
> goto err;
> } else
> phy_power_on(hpriv->port_phys[port]);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
