On Fri, Jan 31, 2014 at 11:54:11AM +0100, Andrew Lunn wrote: > EPROBE_DEFER: We need to fail the probe, but it is not fatal. > ENOSYS: No generic PHY framework, sata_mv can load. > ENODEV: No phy, probably because it is optional and not there, sata_mv can load. > ENOMEM, EINVAL, etc are real errors and should probably be fatal and > returned by the probe function. > > So i could reverse the comparison, look for ENOSYS and ENODEV and > allow the probe to succeed and return the error in all other cases. Or add a helper, e.g. is_phy_error_fatal(), so that the knowledge about specific error codes don't end up getting spread through the code base? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
