Dear Simon Guinot, On Fri, 31 Jan 2014 11:46:44 +0100, Simon Guinot wrote: > > > + /* > > > + * To allow disk hotplug on Armada 370/XP SoCs, the PHY speed must be > > > + * updated in the LP_PHY_CTL register. > > > + */ > > > + if (pdev->dev.of_node && > > > + of_device_is_compatible(pdev->dev.of_node, > > > + "marvell,armada-370-xp-sata")) > > > > Testing whether pdev->dev.of_node is not NULL does not seems to be > > useful. A quick read of of_device_is_compatible() and the function it's > > calling seem to indicate that of_device_is_compatible will return false > > if the passed struct device_node * is NULL. > > I see. > > It seems to me, you already have a patch ready to send. Isn't it ? > Or do you want me to do the update ? I see that your patches have been merged, so I will send followup fixes. Thanks! Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
