On Sun, Jan 19, 2014 at 12:48:48AM +0100, Hans de Goede wrote: > +static int ahci_enable_clks(struct device *dev, struct ahci_host_priv *hpriv) > +{ > + int c, rc; > + > + for (c = 0; c < AHCI_MAX_CLKS && hpriv->clks[c]; c++) { for (c = 0; c < AHCI_MAX_CLKS && !IS_ERR(hpriv->clks[c]); c++) { > + rc = clk_prepare_enable(hpriv->clks[c]); > + if (rc) { > + dev_err(dev, "clock prepare enable failed"); > + goto disable_unprepare_clk; > + } > + } > + return 0; > + > +disable_unprepare_clk: > + while (--c >= 0) > + clk_disable_unprepare(hpriv->clks[c]); > + return rc; > +} > + > +static void ahci_disable_clks(struct ahci_host_priv *hpriv) > +{ > + int c; > + > + for (c = AHCI_MAX_CLKS - 1; c >= 0; c--) > + if (hpriv->clks[c]) if (!IS_ERR(hpriv->clks[c])) > + clk_disable_unprepare(hpriv->clks[c]); > +} > + > +static void ahci_put_clks(struct ahci_host_priv *hpriv) > +{ > + int c; > + > + for (c = 0; c < AHCI_MAX_CLKS && hpriv->clks[c]; c++) for (c = 0; c < AHCI_MAX_CLKS && !IS_ERR(hpriv->clks[c]); c++) > + clk_put(hpriv->clks[c]); > +} Better still for this one, consider using devm_clk_get() - in which case the above is even more important to get right. We really should have a devm_of_clk_get() too. -- FTTC broadband for 0.8mile line: 5.8Mbps down 500kbps up. Estimation in database were 13.1 to 19Mbit for a good line, about 7.5+ for a bad. Estimate before purchase was "up to 13.2Mbit". -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html