Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 10, 2014 at 6:13 PM, Phillip Susi <psusi@xxxxxxxxxx> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> On 01/10/2014 06:11 PM, Brandt, Todd E wrote:
>> Yes yours is simpler, but it also opens a potential memory issue
>> by passing a static int as the return location for the error value.
>> I think it's just safer to tell the callback to attempt no return
>> value at all, and for that you need to expand it into two
>> arguments, one for selection, the other for the output address.
>
> What sort of memory issue?  Also isn't there a system NULL page
> somewhere that could be used?
>

I think the static variable is ok.  We can be sure that all eh threads
are torn down before libata.ko is unloaded.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux