On Thursday, January 09, 2014 9:04 AM, Phillip Susi wrote: > I think my patch for this "libata: resume in the background" was a LOT > simpler. It just used the existing behavior of becoming async when > the async argument was !NULL, and fixed the one caller that didn't > actually care about the result to pass in a pointer anyhow. Yes yours is simpler, but it also opens a potential memory issue by passing a static int as the return location for the error value. I think it's just safer to tell the callback to attempt no return value at all, and for that you need to expand it into two arguments, one for selection, the other for the output address.-- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
