Re: [PATCH 1/5] Phy: DT binding documentation for Marvell MVEBU SATA phy.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 05, 2013 at 10:43:19AM +0100, Andrew Lunn wrote:
> > >  Example:
> > >  
> > >  	sata@80000 {
> > >  		compatible = "marvell,orion-sata";
> > >  		reg = <0x80000 0x5000>;
> > >  		interrupts = <21>;
> > > +		phys = <&sata_phy0>, <&sata_phy1>;
> > > +		phy-names = "0", "1";
> > 
> > more descriptive phy-names? sata-phy0?
> > >  		nr-ports = <2>;
> 
> I could do, but i was following how the clocks work. Unfortunately,
> the binding documentation is out of date and does not contain
> clocks. A real example is:
> 
>               sata@80000 {
>                       compatible = "marvell,orion-sata";
>                       reg = <0x80000 0x5000>;
>                       interrupts = <21>;
>                       clocks = <&gate_clk 14>, <&gate_clk 15>;
>                       clock-names = "0", "1";
>                       phys = <&sata_phy0>, <&sata_phy1>;
>                       phy-names = "0", "1";
>                       status = "disabled";
>               };
> 
> So clocks and the phy are described nearly identically. I can however
> handle phys differently if you wish.

Hi Kishon

Please could you comment on this. Are you O.K. if i use the same
naming scheme for phys as clocks?

Thanks
	Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux