Re: [PATCH -next] ahci: imx: fix the error handling in imx_ahci_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Saturday, December 07, 2013 at 07:00:19 AM, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> 
> Release alloced resources instead of direct return from
> imx_ahci_probe() in the error handling case.
> 
> Fixes: 4a23d1793f8e ('ahci: imx: Add i.MX53 support')
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>

Acked-by: Marek Vasut <marex@xxxxxxx>

Nice find, thanks.

> ---
>  drivers/ata/ahci_imx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/ahci_imx.c b/drivers/ata/ahci_imx.c
> index 2daa288..dd4d6f7 100644
> --- a/drivers/ata/ahci_imx.c
> +++ b/drivers/ata/ahci_imx.c
> @@ -331,7 +331,8 @@ static int imx_ahci_probe(struct platform_device *pdev)
>  		if (IS_ERR(imxpriv->gpr)) {
>  			dev_err(dev,
>  				"failed to find fsl,imx6q-iomux-gpr regmap\n");
> -			return PTR_ERR(imxpriv->gpr);
> +			ret = PTR_ERR(imxpriv->gpr);
> +			goto err_out;
>  		}
> 
>  		/*

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux