On Thu, Nov 07, 2013 at 10:27:08PM -0800, Kuninori Morimoto wrote:
>
> Hi Laurent, Simon
>
> One question
>
> > > +- interrupts : must consist of one interrupt specifier.
> > > +
> > > +Example:
> > > +
> > > +sata: sata@fc600000 {
> > > + compatible = "renesas,sata-r8a7779";
> > > + reg = <0xfc600000 0x2000>;
> > > + interrupt-parent = <&gic>;
> > > + interrupts = <0 100 0x4>;
> >
> > Please use IRQ_TYPE_LEVEL_HIGH instead of 0x4.
>
> Now, our many SoC codes are using 0x4 in "interrupts".
> Do you think we should use IRQ_TYPE_LEVEL_HIGH ?
Personally I think that would be nice.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
