On Oct 28, 2013, at 11:59 PM, Simon Horman wrote: > On Wed, Oct 16, 2013 at 04:06:01PM +0400, Valentine Barshak wrote: >> R-Car Gen2 SoCs have a different PHY which is not compatible >> with the older R-Car H1 (R8A7779) version. >> This adds OF/platform device id tables and PHY initialization >> callbacks for the following Gen2 SoCs: >> * R-Car H2: R8A7790; >> * R-Car M2: R8A7791. >> >> PHY initialization method is chosen based on the device id. >> Default PHY settings are applied for Gen2 SoCs, which should >> suit the Gen2 boards available. >> >> The R8A7779 platform code is modified to use "sata-r8a7779" >> device name. >> >> Signed-off-by: Valentine Barshak <valentine.barshak@xxxxxxxxxxxxxxxxxx> >> --- >> .../devicetree/bindings/ata/sata_rcar.txt | 5 +- >> arch/arm/mach-shmobile/clock-r8a7779.c | 2 +- >> arch/arm/mach-shmobile/setup-r8a7779.c | 2 +- >> drivers/ata/sata_rcar.c | 118 ++++++++++++++++++--- > > Hi Mark, Hi Device-Tree Folks, > > I'm wondering if you have had a chance to look over the bindings > aspect of this and the other patch in the series. I believe that > this series addresses all previous review in that regards. What tree is this binding in? > > Hi Valentine, > > I would like to request that the arch/arm/mach-shmobile/ portion > of this patch be split out into a separate patch. The reason is > that in general it is nicer to apply driver changes separately > to platform changes: for starters they have different maintainers. > And in this case there seems to be no reason not to split the change. > > Also, I would like to this chance to pass on part of a discussion > at the ARM Linux Kernel summit which is that when posting a series of > patches please only CC devicetree@xxxxxxxxxxxxxxx on the patches in > the series that relate to device tree. This would not include > to the new patch with only the arch/arm/mach-shmobile/ portions > of this patch. Feel free to post that patch as a separate series > noting its dependencies below '---' accordingly. > >> 4 files changed, 107 insertions(+), 20 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/ata/sata_rcar.txt b/Documentation/devicetree/bindings/ata/sata_rcar.txt >> index 0719115..d6b20a6 100644 >> --- a/Documentation/devicetree/bindings/ata/sata_rcar.txt >> +++ b/Documentation/devicetree/bindings/ata/sata_rcar.txt >> @@ -1,7 +1,10 @@ >> * Renesas R-Car SATA >> >> Required properties: >> -- compatible : should contain "renesas,sata-r8a7779"; >> +- compatible : should contain one of the following: >> + - "renesas,sata-r8a7779" for R-Car H1 >> + - "renesas,sata-r8a7790" for R-Car H2 >> + - "renesas,sata-r8a7791" for R-Car M2 >> - reg : offset and length of the SATA registers; >> - interrupts : must consist of one interrupt specifier. We normally have an example (not sure if there is one, and just not seeing it because of diff or not). - k -- Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
