Hi Yuvaraj, On 1 October 2013 12:03, Yuvaraj Kumar C D <yuvaraj.cd@xxxxxxxxx> wrote: > +static int exynos_sata_i2c_remove(struct i2c_client *client) > +{ > + dev_info(&client->adapter->dev, > + "detached %s from i2c adapter successfully\n", > + client->name); > + > + return 0; > +} > + Since this function does not do anything, this could be removed. > +static const struct i2c_device_id phy_i2c_device_match[] = { > + { "sata-phy-i2c", 0 }, > +}; > +MODULE_DEVICE_TABLE(of, phy_i2c_device_match); > + > +struct i2c_driver sataphy_i2c_driver = { > + .probe = exynos_sata_i2c_probe, > + .id_table = phy_i2c_device_match, > + .remove = exynos_sata_i2c_remove, > + .driver = { > + .name = "sata-phy-i2c", > + .owner = THIS_MODULE, > + .of_match_table = (void *)phy_i2c_device_match, type casting is not required. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html