On Fri, Aug 09, 2013 at 06:36:19PM +0400, Sergei Shtylyov wrote: > >Ummm... I'm sorry but I'm gonna do 180 from Sergei on this one. The > > That's very unfortunate for me. :-( Hehe, sorry. :) > >So, please put the aux field into ata_taskfile. That's where it > >belongs. > > Can't agree to that. I was going to make 'struct ata_taskfile' > reflect the historical notion and remove from it all not belonging > to that notion. Alas, libata has a bad history of mistreating the > historical terms... But what does sticking to the historical definition give us when the whole concept of TF is no longer maintained in new specs. The distinction between "command proper" and "supporting / plumbing information" is still useful so I think it's natural to assign the former to ata_taskfile and the latter to ata_queuedcmd. After all, there are cases where we want to describe command without all the plumbing stuff libata imposes and given that the aux field is part of FIS proper it might even get used for command results too in the future. I mean, FIS is the new TF. We can rename ata_taskfile to ata_fis and map things the other way but that'd just be extra churn. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
