On Thu, Aug 08, 2013 at 09:49:10PM -0700, Marc C wrote: > From: Marc Carino <marc.ceeeee@xxxxxxxxx> > > SATA 3.1 added an "auxiliary" field to the host-to-device FIS. > > Since there is no analog between the new field and the ATA > taskfile, a new element was added to 'struct ata_queued_cmd." Ummm... I'm sorry but I'm gonna do 180 from Sergei on this one. The auxiliary field is part of ata taskfile for all intents and purposes. FIS is the new command structure anyway and struct ata_taskfile proper should be able to describe the command with ata_queuedcmd providing the surrounding context. The argument that ata_taskfile shouldn't contain anything which wasn't in PATA taskfile is bogus as it already contains ATA_TFLAG_*. So, please put the aux field into ata_taskfile. That's where it belongs. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
