Re[2]: [v3 3/3] sata: imx: add ahci sata support on imx platforms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Fri, Jul 05, 2013 at 05:52:22PM +0800, Richard Zhu wrote:
> > From: Richard Zhu <r65037@xxxxxxxxxxxxx>
...
> > +	if (!(ret & HOST_CAP_SSS))
> > +		writel(ret |= HOST_CAP_SSS, mmio + HOST_CAP);
> 
> Why do you write this conditionally? Just write it unconditionally.

"writel" with assignment is incorrect in any case.

---
��.n��������+%������w��{.n�����{��'^�)��jg��������ݢj����G�������j:+v���w�m������w�������h�����٥





[Index of Archives]     [Linux Filesystems]     [Linux SCSI]     [Linux RAID]     [Git]     [Kernel Newbies]     [Linux Newbie]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Samba]     [Device Mapper]

  Powered by Linux