Hi Alexander: Thanks for your comments. Best Regards Richard Zhu ________________________________________ From: Alexander Shiyan [shc_work@xxxxxxx] Sent: Saturday, July 06, 2013 12:06 AM To: Sascha Hauer Cc: Richard Zhu; Zhu Richard-R65037; shawn.guo@xxxxxxxxxx; rob.herring@xxxxxxxxxxx; linux-ide@xxxxxxxxxxxxxxx; avorontsov@xxxxxxxxxxxxx; jgarzik@xxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx Subject: Re[2]: [v3 3/3] sata: imx: add ahci sata support on imx platforms > On Fri, Jul 05, 2013 at 05:52:22PM +0800, Richard Zhu wrote: > > From: Richard Zhu <r65037@xxxxxxxxxxxxx> ... > > + if (!(ret & HOST_CAP_SSS)) > > + writel(ret |= HOST_CAP_SSS, mmio + HOST_CAP); > > Why do you write this conditionally? Just write it unconditionally. "writel" with assignment is incorrect in any case. [Richard] would be fixed later. --- -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
