On 06/20/2013 07:02 PM, Sergei Shtylyov wrote: > Hello. Hi, Thanks for your comments. > > On 20-06-2013 6:26, Aaron Lu wrote: >> >> +void ata_acpi_hotplug_init(struct ata_host *host) >> +{ >> + int i; >> + >> + for (i = 0; i < host->n_ports; i++) { >> + struct ata_port *ap = host->ports[i]; >> + acpi_handle handle; >> + struct ata_device *dev; >> + >> + if (!ap) >> + continue; >> + >> + handle = ata_ap_acpi_handle(ap); >> + if (handle) { >> + /* we might be on a docking station */ >> + register_hotplug_dock_device(handle, >> + &ata_acpi_ap_dock_ops, ap); > > Please indent this line under the next character after ( above. Is there a link about this rule? I might have missed something about coding style. Thanks, Aaron > >> + } >> + >> + ata_for_each_dev(dev, &ap->link, ALL) { >> + handle = ata_dev_acpi_handle(dev); >> + if (handle) { >> + /* we might be on a docking station */ >> + register_hotplug_dock_device(handle, >> + &ata_acpi_dev_dock_ops, dev); > > Same comment. > > WBR, Sergei > -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html