Tejun, > ata_link_sactive() asks whether there are commands in progress. I > don't think that fits in there. Can't it just bounce to EH for actual > error handling? Why is the link online check necessary? I tried hard to recall why I put ata_link_online() check there, at last I find it was suggested by you in 2009 when you reviewed v2 :-) http://marc.info/?l=linux-ide&m=125170571525422&w=2 Need I submit a patch to remove online check or you will handle it? Thanks, Shane -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html