On Fri, Jun 07, 2013 at 04:29:47AM +0000, Huang, Shane wrote: > > Yeah, it's a bug. ata_link_online() can't be called from interrupt > > handlers. Shane? Can you please look into it? What's the purpose > > of ata_link_online() in ahci_error_intr()? > > ata_link_online() was used to check that pmp link is active... > which should be replaced by ata_link_active()? ata_link_sactive() asks whether there are commands in progress. I don't think that fits in there. Can't it just bounce to EH for actual error handling? Why is the link online check necessary? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
