,On 06/05/2013 06:15 PM, Tejun Heo wrote:
> Hello,
>
> On Wed, Jun 05, 2013 at 05:31:48PM -0500, Mark Langsdorf wrote:
>> +static void ecx_parse_sgpio(struct ecx_plat_data *pdata, u32 port, u32 state)
>> +{
>> + if (state & ECX_ACTIVITY_BITS)
>> + pdata->sgpio_pattern |= sgpio_bit_shift(pdata, port,
>> + ECX_ACTIVITY_SHIFT);
>> + else
>> + pdata->sgpio_pattern &= sgpio_bit_shift(pdata, port,
>> + ECX_ACTIVITY_SHIFT);
>
> Shouldn't it be "&= ~" instead of "&="? You're trying to turn the bit
> off, right?
Oops. Thanks!
--Mark Langsdorf
Calxeda, Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
