On Tuesday 03 April 2012, Ryan Mallon wrote: > On 02/04/12 17:52, Rafal Prylowski wrote: > > > Yes, I already prepared a version of the driver in which IDE register > > addresses are coded as enums instead of using ata_port->ioaddr structure. > > I will post updated version, when I get feedback from Ryan if enums > > or defines are preferred. > > I would prefer defines, simply because it looks odd having an enum which > has multiple names defined to the same value, and most drivers tend to > use defines rather than enums for registers. It's not a big deal though, > and certainly not a show stopper. I tend to prefer enums, but I agree that it's a minor issue and I generally don't even mention it in reviews. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
