On Tue, Sep 06, 2011 at 09:23:01PM +0400, Sergei Shtylyov wrote: > >There were devices which puke on random garbage at the end of CDB and > > Note that ATAPI CDBs are always aligned to 4 bytes, so this path > should never be hit when sending them. Ah, okay, but still, let's just clear it. There's nothing to be gained by not clearing several bytes there. > >in general sending indeterministic garbage to external device is a bad > >idea. It increases chance of problems which can be difficult to > >reproduce and track down while gaining nothing. > > Problems with "don't care" padding bytes? Dunno... Oh yeah, IIRC there were multiple devices which puked on "don't care" garbage bytes in CDB. Don't underestimate the crappiness of cheap ATAPI devices. :) Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
